Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use flag in preflush to indicate whether reorder is required #1298

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

jiacai2050
Copy link
Contributor

Rationale

Current we suggest new primary keys in preflush, and do a reorder in flush task.

There is no easy way for flush task to know if reorder if required.

Detailed Changes

  • Introduce a flag to represent whether reorder is required
  • Change col to ident when build logical plan, ident will not normalize column name.

Test Plan

Integration test.

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit c33ab01 into apache:main Nov 8, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the fix-suggest branch November 22, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants